henryken commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#discussion_r409279710
########## File path: learning/katas/go/Introduction/Hello Beam/Hello Beam Test/go.mod ########## @@ -0,0 +1,25 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +module hello_beam_test + +go 1.13 + +require ( Review comment: My IDE suggests that there are some missing indirect modules, i.e. x/lint, x/tools, go/tools. Are those required to be committed? ```go require ( github.com/apache/beam v2.19.0+incompatible github.com/golang/protobuf v1.3.5 // indirect github.com/google/go-cmp v0.4.0 // indirect golang.org/x/lint v0.0.0-20190313153728-d0100b6bd8b3 // indirect golang.org/x/tools v0.0.0-20190524140312-2c0ae7006135 // indirect google.golang.org/grpc v1.28.1 // indirect honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc // indirect ) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
