pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] 
Improvements for FnApiRunner
URL: https://github.com/apache/beam/pull/11270#discussion_r408507610
 
 

 ##########
 File path: 
sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
 ##########
 @@ -75,21 +75,27 @@
 
 IMPULSE_BUFFER = b'impulse'
 
+# SideInputId is identified by a consumer ParDo + tag.
+SideInputId = Tuple[str, str]
+
+DataSideInput = Dict[SideInputId,
 
 Review comment:
   The value is a tuple with the encoded data. I've moved these to 
translations.py, and updated the comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to