pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608]
Improvements for FnApiRunner
URL: https://github.com/apache/beam/pull/11270#discussion_r408508964
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -75,21 +75,27 @@
IMPULSE_BUFFER = b'impulse'
+# SideInputId is identified by a consumer ParDo + tag.
+SideInputId = Tuple[str, str]
+
+DataSideInput = Dict[SideInputId,
+ Tuple[bytes, beam_runner_api_pb2.FunctionSpec]]
+
class Stage(object):
"""A set of Transforms that can be sent to the worker for processing."""
def __init__(self,
name, # type: str
transforms, # type: List[beam_runner_api_pb2.PTransform]
- downstream_side_inputs=None, # type: Optional[FrozenSet[str]]
+ downstream_side_inputs=None, # type: Optional[Dict[str,
SideInputId]]
Review comment:
Hm so this change breaks that, so the memory requirements would be larger. I
would think that they would not be too bad, since most graphs don't have many
side inputs going many places. What do you think? I'm willing to find a better
solution for this, but I wonder if it's worth the extra time.
The reason that this is made into a dict is to contain more information
about downstream side inputs. specifically, it contains which transforms will
consume the side inputs. this is used to commit the side inputs to state after
they are calculated (rather than before they are consumed). This will be
necessary for streaming, because side inputs will need to be added to state as
they are computed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
