lukecwik commented on a change in pull request #11418: [BEAM-8872] Support
split at fraction for OffsetRangeTracker
URL: https://github.com/apache/beam/pull/11418#discussion_r409806021
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRangeTrackerTest.java
##########
@@ -47,16 +48,9 @@ public void testTryClaim() throws Exception {
@Test
public void testCheckpointUnstarted() throws Exception {
OffsetRangeTracker tracker = new OffsetRangeTracker(new OffsetRange(100,
200));
- expected.expect(IllegalStateException.class);
- tracker.trySplit(0).getResidual();
- }
-
- @Test
- public void testCheckpointOnlyFailedClaim() throws Exception {
- OffsetRangeTracker tracker = new OffsetRangeTracker(new OffsetRange(100,
200));
- assertFalse(tracker.tryClaim(250L));
- expected.expect(IllegalStateException.class);
- OffsetRange checkpoint = tracker.trySplit(0).getResidual();
+ SplitResult res = tracker.trySplit(0);
+ assertEquals(new OffsetRange(100, 100), res.getPrimary());
+ assertEquals(new OffsetRange(100, 200), res.getResidual());
Review comment:
primary and residual shouldn't have the same value, primary should be an
empty range like `[100, 100)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
