lukecwik commented on a change in pull request #11418: [BEAM-8872] Support
split at fraction for OffsetRangeTracker
URL: https://github.com/apache/beam/pull/11418#discussion_r409806889
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvoker.java
##########
@@ -210,9 +210,10 @@ public FinishBundleContext
finishBundleContext(DoFn<InputT, OutputT> doFn) {
// the call says that not the whole restriction has been processed. So
we need to take
// a checkpoint now: checkpoint() guarantees that the primary
restriction describes exactly
// the work that was done in the current ProcessElement call, and
returns a residual
- // restriction that describes exactly the work that wasn't done in the
current call.
+ // restriction that describes exactly the work that wasn't done in the
current call. The
+ // residual is null when the entire restriction has been processed.
if (processContext.numClaimedBlocks > 0) {
- residual = checkNotNull(processContext.takeCheckpointNow());
+ residual = processContext.takeCheckpointNow();
Review comment:
takeCheckpointNow should work regardless whether numClaimedBlocks > 0 or not.
Even if tryClaim never happens, the watermark may advance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
