lukecwik commented on a change in pull request #11418: [BEAM-8872] Support
split at fraction for OffsetRangeTracker
URL: https://github.com/apache/beam/pull/11418#discussion_r409820103
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/SplittableProcessElementInvoker.java
##########
@@ -51,11 +51,6 @@ public Result(
@Nullable WatermarkEstimatorStateT futureWatermarkEstimatorState) {
checkArgument(continuation != null, "continuation must not be null");
this.continuation = continuation;
- if (continuation.shouldResume()) {
- checkArgument(
- residualRestriction != null,
- "residual restriction must not be null if continuation indicate it
should resume");
- }
this.residualRestriction = residualRestriction;
this.futureOutputWatermark = futureOutputWatermark;
this.futureWatermarkEstimatorState = futureWatermarkEstimatorState;
Review comment:
I believe the comment below could be incorrect. If we get stop(), we
shouldn't have a residual restriction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
