iemejia commented on a change in pull request #11454: [BEAM-8871] Support
trySplit for ByteKeyRangeTracker
URL: https://github.com/apache/beam/pull/11454#discussion_r410480834
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/ByteKeyRange.java
##########
@@ -218,6 +218,10 @@ public double estimateFractionForKey(ByteKey key) {
public ByteKey interpolateKey(double fraction) {
checkArgument(
fraction >= 0.0 && fraction < 1.0, "Fraction %s must be in the range
[0, 1)", fraction);
+ // Return starKey when fraction is 0 in order to avoid adding trailing
zeros during computation.
Review comment:
s/starKey/startKey
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
