lukecwik commented on a change in pull request #11454: [BEAM-8871] Support
trySplit for ByteKeyRangeTracker
URL: https://github.com/apache/beam/pull/11454#discussion_r410594056
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/splittabledofn/ByteKeyRangeTrackerTest.java
##########
@@ -287,4 +318,30 @@ public void testBacklogPartiallyCompleted() {
tracker.tryClaim(ByteKey.of(0xa0));
assertThat(tracker.getSize(), allOf(greaterThan(0.), lessThan(1.)));
}
+
+ /** Asserts the two ByteKey are equal except trailing zeros. */
+ private static void assertByteKeyEqualExceptPadding(ByteKey expected,
ByteKey key) {
Review comment:
Make that method public and call it from this test since they are both in
the same module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
