lukecwik commented on a change in pull request #11454: [BEAM-8871] Support
trySplit for ByteKeyRangeTracker
URL: https://github.com/apache/beam/pull/11454#discussion_r410593566
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java
##########
@@ -80,6 +81,7 @@
* represent based upon the current known remaining amount of work.
* @return a {@link SplitResult} if a split was possible, otherwise returns
{@code null}.
Review comment:
We should make it clear that a checkpoint must return a valid split result
or null where null represents that there is no residual.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
