tysonjh commented on a change in pull request #12001:
URL: https://github.com/apache/beam/pull/12001#discussion_r440918707
##########
File path:
runners/extensions-java/metrics/src/main/java/org/apache/beam/runners/extensions/metrics/MetricsHttpSink.java
##########
@@ -50,6 +49,12 @@ public MetricsHttpSink(MetricsOptions pipelineOptions) {
this.urlString = pipelineOptions.getMetricsHttpSinkUrl();
}
+ /**
+ * Writes the metricQueryResults via HTTP POST to metrics sink endpoint.
+ *
+ * @param metricQueryResults query results to write.
+ * @throws Exception throws IOException for non-200 response from endpoint.
+ */
Review comment:
You're welcome.
##########
File path:
runners/extensions-java/metrics/src/main/java/org/apache/beam/runners/extensions/metrics/MetricsHttpSink.java
##########
@@ -86,8 +93,8 @@ public MetricNameSerializer(Class<MetricName> t) {
public void serialize(MetricName value, JsonGenerator gen,
SerializerProvider provider)
throws IOException {
gen.writeStartObject();
- gen.writeObjectField("name", value.name());
- gen.writeObjectField("namespace", value.namespace());
Review comment:
These were deprecated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
