echauchot commented on pull request #12001:
URL: https://github.com/apache/beam/pull/12001#issuecomment-646537163
LGTM! Thanks for the changes, that's perfect. Last thing to do is clean
review comments: can you squash the first 2 commits and leave only the comment
about dependency. The 3rd commit needs to be appart IMHO because it changes the
(deprecated) API. Though, reword it to: "remove deprecated MetricName.name()
and MetricName.namespace() methods and fix a typo".
regarding build failure, it's an unrelated timeout, a new build will be
triggered when you push.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
