tysonjh commented on a change in pull request #12001:
URL: https://github.com/apache/beam/pull/12001#discussion_r441875810
##########
File path:
runners/extensions-java/metrics/src/main/java/org/apache/beam/runners/extensions/metrics/MetricsHttpSink.java
##########
@@ -86,8 +93,8 @@ public MetricNameSerializer(Class<MetricName> t) {
public void serialize(MetricName value, JsonGenerator gen,
SerializerProvider provider)
throws IOException {
gen.writeStartObject();
- gen.writeObjectField("name", value.name());
- gen.writeObjectField("namespace", value.namespace());
Review comment:
Got it, I was just doing some code cleaning as I went along. I've
verified that removing the deprecated methods doesn't break anything and added
that to this PR. I'll update the commit message as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
