yeandy commented on code in PR #21781:
URL: https://github.com/apache/beam/pull/21781#discussion_r898188462


##########
sdks/python/test-suites/direct/common.gradle:
##########
@@ -213,8 +213,30 @@ task torchTests {
     }
 }
 
+task sklearnInferenceTest {
+  dependsOn 'installGcpTest'
+  dependsOn ':sdks:python:sdist'
+  doLast {
+      def testOpts = basicTestOpts
+      def argMap = [
+          "test_opts": testOpts,
+          "suite": "postCommitIT-direct-py${pythonVersionSuffix}",
+          "collect": "it_run_inference",

Review Comment:
   Do we want to add `it_postcommit`?
   
   Will `it_run_inference` also be needed to be added to the pytorch examples? 
unless it's specifically for non-pytorch inference tests? Are there concerns 
with us creating too many of these tags to keep track which ones to use?



##########
sdks/python/test-suites/direct/common.gradle:
##########
@@ -213,8 +213,30 @@ task torchTests {
     }
 }
 

Review Comment:
   ```suggestion
   // Scikit-learn RunInference IT tests
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to