AnandInguva commented on code in PR #21781:
URL: https://github.com/apache/beam/pull/21781#discussion_r898198034
##########
sdks/python/test-suites/direct/common.gradle:
##########
@@ -213,8 +213,30 @@ task torchTests {
}
}
+task sklearnInferenceTest {
+ dependsOn 'installGcpTest'
+ dependsOn ':sdks:python:sdist'
+ doLast {
+ def testOpts = basicTestOpts
+ def argMap = [
+ "test_opts": testOpts,
+ "suite": "postCommitIT-direct-py${pythonVersionSuffix}",
+ "collect": "it_run_inference",
Review Comment:
Yes, it needs to be added to the torch tests. As of now, its not needed
because you already have a marker `use_pytorch` which we use in tox
environment. we make use of the `use_pytorch` to collect torch it test as
well. `it_run_inference` replaces the condition `use_pytorch` and
`it_postcommit`
We are going to create tags for frameworks that needs extra dependencies to
run unit tests in the tox environment.
`it_run_inference ` would be sufficient for all the RunInference IT tests
and I think `it_postcommit` is not required anymore.
Once this change goes in, I will make a change for other torch IT tests but
its not a priority as of now
##########
sdks/python/test-suites/direct/common.gradle:
##########
@@ -213,8 +213,30 @@ task torchTests {
}
}
+task sklearnInferenceTest {
+ dependsOn 'installGcpTest'
+ dependsOn ':sdks:python:sdist'
+ doLast {
+ def testOpts = basicTestOpts
+ def argMap = [
+ "test_opts": testOpts,
+ "suite": "postCommitIT-direct-py${pythonVersionSuffix}",
+ "collect": "it_run_inference",
Review Comment:
Yes, it needs to be added to the torch tests. As of now, its not needed
because you already have a marker `use_pytorch` which we use in tox
environment. we make use of the `use_pytorch` to collect torch it test as
well. `it_run_inference` replaces the condition `use_pytorch` and
`it_postcommit` for pytest markers.
We are going to create tags for frameworks that needs extra dependencies to
run unit tests in the tox environment.
`it_run_inference ` would be sufficient for all the RunInference IT tests
and I think `it_postcommit` is not required anymore.
Once this change goes in, I will make a change for other torch IT tests but
its not a priority as of now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
