tvalentyn commented on code in PR #21781:
URL: https://github.com/apache/beam/pull/21781#discussion_r898313808
##########
sdks/python/test-suites/direct/common.gradle:
##########
@@ -213,8 +213,30 @@ task torchTests {
}
}
+task sklearnInferenceTest {
+ dependsOn 'installGcpTest'
+ dependsOn ':sdks:python:sdist'
+ doLast {
+ def testOpts = basicTestOpts
+ def argMap = [
+ "test_opts": testOpts,
+ "suite": "postCommitIT-direct-py${pythonVersionSuffix}",
+ "collect": "it_run_inference",
Review Comment:
I also got confused by this.
IMO it would be easier to keep consistency with current structure
(uses_scikit_learn + it_postcommit), and then replace the with new structure at
once/if you to join pytest and sklearn into one suite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
