alexeyinkin commented on code in PR #21926:
URL: https://github.com/apache/beam/pull/21926#discussion_r900364292
##########
playground/frontend/lib/modules/analytics/analytics_service.dart:
##########
@@ -16,119 +16,27 @@
* limitations under the License.
*/
-import 'package:flutter/cupertino.dart';
-import 'package:playground/config.g.dart';
-import 'package:playground/modules/analytics/analytics_events.dart';
+import 'package:flutter/widgets.dart';
import 'package:playground/modules/examples/models/example_model.dart';
import 'package:playground/modules/sdk/models/sdk.dart';
import 'package:provider/provider.dart';
-import 'package:usage/usage_html.dart';
-
-class AnalyticsService {
- late final Analytics _analytics;
-
- AnalyticsService() {
- _analytics = AnalyticsHtml(kAnalyticsUA, 'beam', '1.0');
- }
+abstract class AnalyticsService {
static AnalyticsService get(BuildContext context) {
return Provider.of<AnalyticsService>(context, listen: false);
}
- void trackSelectSdk(SDK oldSdk, SDK newSdk) {
- safeSendEvent(
- kSdkCategory,
- kSelectSdkEvent,
- label: '${oldSdk.displayName}_${newSdk.displayName}',
- );
- }
-
- void trackSelectExample(ExampleModel newExample) {
- safeSendEvent(
- kExampleCategory,
- kSelectExampleEvent,
- label: newExample.path,
- );
- }
-
- void trackClickNewExample() {
- safeSendEvent(kExampleCategory, kClickNewExampleEvent);
- }
-
- void trackReset() {
- safeSendEvent(kCommonCategory, kClickResetEvent);
- }
-
- void trackClickToggleTheme(bool isDark) {
- safeSendEvent(
- kCommonCategory,
- kClickToggleThemeEvent,
- label: isDark ? 'dark' : 'light',
- );
- }
-
- void trackOpenShortcutsModal() {
- safeSendEvent(kCommonCategory, kOpenShortcutsModalEvent);
- }
-
- void trackOpenLink(String link) {
- safeSendEvent(
- kLinkCategory,
- kOpenShortcutsModalEvent,
Review Comment:
This line had been logging `open_shortcuts_modal` event instead of
`open_link`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
