alexeyinkin commented on code in PR #21926:
URL: https://github.com/apache/beam/pull/21926#discussion_r900374197
##########
playground/frontend/lib/pages/playground/components/editor_textarea_wrapper.dart:
##########
@@ -104,11 +107,8 @@ class CodeTextAreaWrapper extends StatelessWidget {
AnalyticsService analyticsService =
AnalyticsService.get(context);
final stopwatch = Stopwatch()..start();
- final exampleName = getAnalyticsExampleName(
- state.selectedExample,
- state.isExampleChanged,
- state.sdk,
- );
+ final exampleName = getAnalyticsExampleName(state);
Review Comment:
This method is changed to only accept `PlaygroundState` for the following
reasons:
- In both its uses, all the properties are taken from `PlaygroundState`
anyway.
- It's not a widget's business to know what exact properties form the name
for analytics.
- This decoupling will allow to easily change how we produce the name for
analytics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
