alexeyinkin commented on code in PR #21926:
URL: https://github.com/apache/beam/pull/21926#discussion_r900371670
##########
playground/frontend/lib/pages/embedded_playground/components/embedded_appbar_title.dart:
##########
@@ -53,20 +57,18 @@ class EmbeddedAppBarTitle extends StatelessWidget {
},
runCode: () {
final stopwatch = Stopwatch()..start();
- final exampleName = getAnalyticsExampleName(
- state.selectedExample,
- state.isExampleChanged,
- state.sdk,
- );
+ final exampleName = getAnalyticsExampleName(state);
+ final analyticsService = AnalyticsService.get(context);
+
state.runCode(
onFinish: () {
- AnalyticsService.get(context).trackRunTimeEvent(
Review Comment:
This had been possessing the same risk of invalidated `context` as the bug
above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
