y1chi commented on a change in pull request #11993:
URL: https://github.com/apache/beam/pull/11993#discussion_r442563703
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -3808,15 +3817,24 @@ public void onTimer(
TestStream<KV<String, Integer>> stream =
TestStream.create(KvCoder.of(StringUtf8Coder.of(), VarIntCoder.of()))
// See GlobalWindow,
- // END_OF_GLOBAL_WINDOW is
TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1))
-
.advanceWatermarkTo(BoundedWindow.TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1)))
+ // END_OF_GLOBAL_WINDOW is
TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1)),
Review comment:
we can also explicitly set timer with absolute time equal to the same
fire time the with original
`timer.align(Duration.standardDays(1)).setRelative();`, would that make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
