y1chi commented on a change in pull request #11993:
URL: https://github.com/apache/beam/pull/11993#discussion_r445836802
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -3817,24 +3817,15 @@ public void onTimer(
TestStream<KV<String, Integer>> stream =
TestStream.create(KvCoder.of(StringUtf8Coder.of(), VarIntCoder.of()))
// See GlobalWindow,
- // END_OF_GLOBAL_WINDOW is
TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1)),
- // minus 775 milliseconds to make the grainularity to second as
required by dataflow
- // for TestStream.
- .advanceWatermarkTo(
- BoundedWindow.TIMESTAMP_MAX_VALUE
- .minus(Duration.standardDays(1))
- .minus(BoundedWindow.TIMESTAMP_MAX_VALUE.getMillis() %
1000))
+ // END_OF_GLOBAL_WINDOW is
TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1))
+
.advanceWatermarkTo(BoundedWindow.TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1)))
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
