y1chi commented on a change in pull request #11993:
URL: https://github.com/apache/beam/pull/11993#discussion_r444343155
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -3808,15 +3817,24 @@ public void onTimer(
TestStream<KV<String, Integer>> stream =
TestStream.create(KvCoder.of(StringUtf8Coder.of(), VarIntCoder.of()))
// See GlobalWindow,
- // END_OF_GLOBAL_WINDOW is
TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1))
-
.advanceWatermarkTo(BoundedWindow.TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1)))
+ // END_OF_GLOBAL_WINDOW is
TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1)),
Review comment:
@acrites and I chatted about some of the tests. There is an option to
alter the windmill wm_work_set_watermark_resolution_usec and
dataflow_watermark_resolution_usec so that the AdvanceWatermark and
AdvanceProcessingTime can deal with milliseconds. But it requires additional
test framework plumbing. Should we keep this test as it was and try to
unsickbay it after we can set the windmill flag values?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
