egalpin commented on code in PR #22216:
URL: https://github.com/apache/beam/pull/22216#discussion_r927955854
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubCoderProviderRegistrar.java:
##########
@@ -31,6 +31,7 @@ public class PubsubCoderProviderRegistrar implements
CoderProviderRegistrar {
@Override
public List<CoderProvider> getCoderProviders() {
return ImmutableList.of(
+ CoderProviders.forCoder(TypeDescriptor.of(PubsubMessage.class),
PubsubMessageCoder.of()),
Review Comment:
I'm not 100% confident in the order that is required here, or if order
matters. I couldn't find documentation around how coders are resolved when
multiple coders are registered for the same class. I tried tracing the code
but wasn't able to come up with a definitive answer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
