TheNeuralBit commented on code in PR #22561:
URL: https://github.com/apache/beam/pull/22561#discussion_r941599556
##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -647,9 +648,36 @@ def _from_typing(cls, typ):
('micros', np.int64)])
[email protected]_logical_type
+class DateTimeLogicalType(NoArgumentLogicalType[Timestamp, np.int64]):
Review Comment:
I'm confused though, how did we get a field with URN
`beam:logical_type:datetime:v1`? Based on the change in JdbcUtil I thought the
intention here was to map JDBC timestamp columns to the MicrosInstant logical
type, with URN `beam:logical_type:micros_instant:v1`, in order to avoid the
proiblematic InstantCoder in DATETIME.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
