TheNeuralBit commented on code in PR #22561:
URL: https://github.com/apache/beam/pull/22561#discussion_r941739763
##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -647,9 +648,36 @@ def _from_typing(cls, typ):
('micros', np.int64)])
[email protected]_logical_type
+class DateTimeLogicalType(NoArgumentLogicalType[Timestamp, np.int64]):
Review Comment:
Can we make portable timestamp and java timestamp the same type? I think it
would be preferable to produce micros_instant for the timestamp type in the
JDBC read. I'd really like to avoid having the Java's DATETIME primitive leak
into Python.
##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -647,9 +648,36 @@ def _from_typing(cls, typ):
('micros', np.int64)])
[email protected]_logical_type
+class DateTimeLogicalType(NoArgumentLogicalType[Timestamp, np.int64]):
Review Comment:
Can we make portable timestamp and java timestamp the same type? I think it
would be preferable to produce micros_instant for the timestamp type in the
JDBC read. I'd really like to avoid having Java's DATETIME primitive leak into
Python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
