Abacn commented on code in PR #22561:
URL: https://github.com/apache/beam/pull/22561#discussion_r941645429
##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -647,9 +648,36 @@ def _from_typing(cls, typ):
('micros', np.int64)])
[email protected]_logical_type
+class DateTimeLogicalType(NoArgumentLogicalType[Timestamp, np.int64]):
Review Comment:
I tried to change coder for Instant in java side but it did not quite work
(see comment
[here](https://github.com/apache/beam/issues/19817#issuecomment-1204222164))
and ended up adding support for InstantCoder coded timestamp in Python side. I
understand this is less elegant but it does not touch java Instant coders which
is used everywhere not only in schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
