Abacn commented on code in PR #23635:
URL: https://github.com/apache/beam/pull/23635#discussion_r998480542


##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java:
##########
@@ -448,6 +451,39 @@ public static String 
getExternalServiceAddress(PortablePipelineOptions options)
     return environmentOption;
   }
 
+  /**
+   * Configure log manager's default log level and log level overrides from 
the sdk harness options,
+   * and return the list of configured loggers.
+   */
+  public static List<java.util.logging.Logger> getConfiguredLoggerFromOptions(

Review Comment:
   Was trying to find the best place to put these piece of code that sets log 
levels. It is now used by both `:sdks:java:harness` and `:runners:flink`. Seems 
like this module is a good place as there are other static public methods 
related to environments here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to