tvalentyn commented on code in PR #23635:
URL: https://github.com/apache/beam/pull/23635#discussion_r998682297
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineRunner.java:
##########
@@ -67,14 +69,18 @@ public class FlinkPipelineRunner implements
PortablePipelineRunner {
public FlinkPipelineRunner(
FlinkPipelineOptions pipelineOptions, @Nullable String confDir,
List<String> filesToStage) {
this.pipelineOptions = pipelineOptions;
- this.confDir = confDir;
+ // confDir takes precedence than pipelineOptions.getFlinkConfDir
+ this.confDir = confDir != null ? confDir :
pipelineOptions.getFlinkConfDir();
this.filesToStage = filesToStage;
}
@Override
public PortablePipelineResult run(final Pipeline pipeline, JobInfo jobInfo)
throws Exception {
MetricsEnvironment.setMetricsSupported(false);
+ // Apply log levels settings at the beginning of pipeline run
Review Comment:
do we need a similar change in
https://github.com/apache/beam/blob/master/runners/spark/src/main/java/org/apache/beam/runners/spark/SparkPipelineRunner.java
? Can be a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
