Abacn commented on code in PR #23635:
URL: https://github.com/apache/beam/pull/23635#discussion_r998695661
##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java:
##########
@@ -448,6 +451,39 @@ public static String
getExternalServiceAddress(PortablePipelineOptions options)
return environmentOption;
}
+ /**
+ * Configure log manager's default log level and log level overrides from
the sdk harness options,
+ * and return the list of configured loggers.
+ */
+ public static List<java.util.logging.Logger> getConfiguredLoggerFromOptions(
Review Comment:
SdkHarnessOptions.java is in sdks:java:core and yes it is accessible.
Considered it and I was not sure if it is a good pattern to include some code
that have side effect on the environment in the option class. If it sounds
reasonable could move it in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
