Abacn commented on code in PR #23635:
URL: https://github.com/apache/beam/pull/23635#discussion_r999844890
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineRunner.java:
##########
@@ -67,14 +68,18 @@ public class FlinkPipelineRunner implements
PortablePipelineRunner {
public FlinkPipelineRunner(
FlinkPipelineOptions pipelineOptions, @Nullable String confDir,
List<String> filesToStage) {
this.pipelineOptions = pipelineOptions;
- this.confDir = confDir;
+ // confDir takes precedence than pipelineOptions.getFlinkConfDir
Review Comment:
I observe the option does not take effect when invoking a Python pipeline
and I targeted the code here. It may be related to What @kennknowles mentioned
below there is a "non-portable mode" and also a "portable mode" having
different entry points for environment settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
