tvalentyn commented on code in PR #23635:
URL: https://github.com/apache/beam/pull/23635#discussion_r999828902
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineRunner.java:
##########
@@ -67,14 +68,18 @@ public class FlinkPipelineRunner implements
PortablePipelineRunner {
public FlinkPipelineRunner(
FlinkPipelineOptions pipelineOptions, @Nullable String confDir,
List<String> filesToStage) {
this.pipelineOptions = pipelineOptions;
- this.confDir = confDir;
+ // confDir takes precedence than pipelineOptions.getFlinkConfDir
Review Comment:
Found origins of this flag:
From: https://issues.apache.org/jira/browse/BEAM-14492
```
Sometimes it is necessary to be able to set any flink option via
PipelineOptions to the runner - mostly when we submit job from vanilla Java,
not being run via flink run
```
https://github.com/apache/beam/pull/17715
I think the intent is consistent with the usage that if a user specifies
this via pipeline options, it should take precedence over predetermined runner
configuration.
cc'ing @je-ik just in case and FYI since you mention that ```originally
pipelineOptions's flinkConfDir did not take effect at all.```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
