Abacn commented on code in PR #23635:
URL: https://github.com/apache/beam/pull/23635#discussion_r999815001
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineRunner.java:
##########
@@ -67,14 +68,18 @@ public class FlinkPipelineRunner implements
PortablePipelineRunner {
public FlinkPipelineRunner(
FlinkPipelineOptions pipelineOptions, @Nullable String confDir,
List<String> filesToStage) {
this.pipelineOptions = pipelineOptions;
- this.confDir = confDir;
+ // confDir takes precedence than pipelineOptions.getFlinkConfDir
Review Comment:
At a first glance I understood `confDir` parameter as an override to
`pipelineOptions.getFlinkConfDir` in `FlinkPipelineRunner's` constructor.
One use case is that the command lines argument of
https://github.com/apache/beam/blob/3edff6a7cf3c57e4589837f2714dbdd981a32063/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineRunner.java#L160
could pass to `FlinkPipelineRunnerConfiguration ` and finally appears as
`confDir` parameter here. According to the comment of
https://github.com/apache/beam/blob/3edff6a7cf3c57e4589837f2714dbdd981a32063/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineRunner.java#L213
I understand that if `confDir` is set it should take precedence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
