chamikaramj commented on code in PR #23765:
URL: https://github.com/apache/beam/pull/23765#discussion_r1010762641
##########
sdks/python/apache_beam/transforms/periodicsequence.py:
##########
@@ -50,6 +50,10 @@ def create_tracker(self, restriction):
def restriction_size(self, unused_element, restriction):
return restriction.size()
+ # On drain, immediately stop emitting new elements
Review Comment:
Pls consider adding a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
