damccorm commented on code in PR #23765:
URL: https://github.com/apache/beam/pull/23765#discussion_r1010776866
##########
sdks/python/apache_beam/transforms/periodicsequence.py:
##########
@@ -50,6 +50,10 @@ def create_tracker(self, restriction):
def restriction_size(self, unused_element, restriction):
return restriction.size()
+ # On drain, immediately stop emitting new elements
Review Comment:
I thought about it, but it seems like more trouble/flake risk than its
worth. Testing this effectively would pretty much need to be an integration
test on dataflow, and right now we don't have that capability (triggering a
drain) built into our test framework. We could add a unit test that truncate
always returns none on this restriction, but that seems like overkill (and goes
beyond any of the testing we generally apply to truncate or restrictions
generally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
