seungjin-an commented on code in PR #24276:
URL: https://github.com/apache/beam/pull/24276#discussion_r1036734718
##########
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ConfigContext.java:
##########
@@ -35,12 +34,17 @@ public class ConfigContext {
private final Map<PValue, String> idMap;
private AppliedPTransform<?, ?, ?> currentTransform;
private final SamzaPipelineOptions options;
- private final Set<String> stateIds;
+ private final Map<String, String> usedStateIdMap;
+ private final Map<String, String> multiParDoStateIdMap;
Review Comment:
Sounds good - made the change.
##########
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/TranslationContext.java:
##########
@@ -249,6 +252,19 @@ public String getTransformId() {
return idGenerator.getId(getTransformFullName());
}
+ /** Given a set of user stateIds and parDo name, return a stateId to storeId
map. */
+ public Map<String, String> getStateIdToStoreIdMap(Set<String> stateIds,
String escapedParDoName) {
+ final Map<String, String> storeIds = new HashMap<>();
+ stateIds.forEach(
+ stateId ->
+ storeIds.put(
+ stateId,
+ multiParDoStateIds.contains(stateId)
+ ? String.join("-", stateId, escapedParDoName)
Review Comment:
Done. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
