seungjin-an commented on code in PR #24276:
URL: https://github.com/apache/beam/pull/24276#discussion_r1036736271
##########
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/SamzaStoreStateInternals.java:
##########
@@ -129,18 +130,7 @@ static KeyValueStore<ByteArray, StateValue<?>>
getBeamStore(TaskContext context)
*/
static <K> Factory<K> createNonKeyedStateInternalsFactory(
String id, TaskContext context, SamzaPipelineOptions pipelineOptions) {
- return createStateInternalsFactory(id, null, context, pipelineOptions,
Collections.emptySet());
- }
-
- static <K> Factory<K> createStateInternalsFactory(
Review Comment:
As we fetch stateIds from DoFnSignature earlier in the logic for handling
stateIds with multiParDo, I've replaced this with using stateIdMap (map of
stateId to RocksDB storeId). Would we prefer to add this back for future use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
