seungjin-an commented on PR #24276:
URL: https://github.com/apache/beam/pull/24276#issuecomment-1334976976
> Two main issues:
>
> 1. no rewriting of configs, instead, do a prescan of pipeline and build
the non-unique state id set
> 2. the changes in the SamzaStateInternals are not needed if you make the
stores map still follow the same definition of {stateId -> store}. The state
internals is generated per PTransform so it will not have dups here.
Thank you so much for taking the time reviewing, providing suggestions on
the pre-scan/ better naming, and fixing my understanding in
SamzaStoreInternals. I have addressed all the comments and please have another
look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
