Hannah-Jiang commented on a change in pull request #12216:
URL: https://github.com/apache/beam/pull/12216#discussion_r452974413
##########
File path: sdks/java/container/build.gradle
##########
@@ -77,7 +77,9 @@ golang {
import com.github.jk1.license.render.*
licenseReport {
outputDir = 'java_third_party_licenses'
- projects = [project.rootProject] + project.rootProject.subprojects
+ projects = [project,
+ project.rootProject.findProject(':sdks:java:harness'),
+ project.rootProject.findProject(':sdks:java:io:kafka')]
Review comment:
Does this change include all dependencies installed in container? If so,
it looks good for now.
This list should evolve if more dependencies are added to container, so we
need to make it clear somewhere for developers who add new dependencies to
container.
A minor update to [release
guide](https://github.com/apache/beam/blob/master/website/www/site/content/en/contribute/release-guide.md)
is needed. There is a step to check if all licenses are added by checking the
number of licenses. Now we expect to see roughly 1400 dependencies. With this
change, I think the number is reduced? Then the guide should be updated with a
new number or find a better way to check if all expected licenses are included.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
