kennknowles commented on a change in pull request #12216:
URL: https://github.com/apache/beam/pull/12216#discussion_r452978170
##########
File path: sdks/java/container/build.gradle
##########
@@ -77,7 +77,9 @@ golang {
import com.github.jk1.license.render.*
licenseReport {
outputDir = 'java_third_party_licenses'
- projects = [project.rootProject] + project.rootProject.subprojects
+ projects = [project,
+ project.rootProject.findProject(':sdks:java:harness'),
+ project.rootProject.findProject(':sdks:java:io:kafka')]
Review comment:
Hmmm. When I ran `:sdks:java:container:generateLicenseReport` before
this PR I got 50 dependencies. After this PR I got 55. See the diff in the
description. It mostly added new deps. The ones removed were:
- `checker-qual-3.4.1.jar`: this is `compileOnly` so we don't need it...
but it should be in the configuration I chose...
- `hadoop-apache2-3.2.0-1.jar`: I hope this is not in the container!
- `icu4j-58.2.jar`: I don't know
- `objenesis-2.6.jar`: I don't know
- `woodstox-core-asl-4.4.1.jar`: I don't know
But it sounds like there's another problem because I should be able to repro
and get 1400 licenses at head.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
