Hannah-Jiang commented on a change in pull request #12216:
URL: https://github.com/apache/beam/pull/12216#discussion_r452993301
##########
File path: sdks/java/container/build.gradle
##########
@@ -77,7 +77,9 @@ golang {
import com.github.jk1.license.render.*
licenseReport {
outputDir = 'java_third_party_licenses'
- projects = [project.rootProject] + project.rootProject.subprojects
+ projects = [project,
+ project.rootProject.findProject(':sdks:java:harness'),
+ project.rootProject.findProject(':sdks:java:io:kafka')]
Review comment:
Yep, need to run `pullLicenses` task with `--docker-pull-licenses`
options. `generateLicenseReport` task pulls licenses from jars. If licenses are
not distributed within jar, they are ignored. `pullLicenses` task pulls those
missing licenses, so will have more licenses. But I don't think the gap should
be 50 vs 1400.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
