damccorm commented on code in PR #24819:
URL: https://github.com/apache/beam/pull/24819#discussion_r1059133365
##########
.github/workflows/playground_examples_ci_reusable.yml:
##########
@@ -67,7 +67,7 @@ jobs:
if [ -z "$BASE_REF" ] || [ "$BASE_REF" == "master" ]; then
BASE_REF=origin/master
fi
- DIFF=$(git diff --name-only $BASE_REF $GITHUB_SHA | tr '\n' ' ')
+ DIFF=$(git diff --name-only --diff-filter=d $BASE_REF $GITHUB_SHA |
tr '\n' ' ')
Review Comment:
If there are deleted files, wouldn't we still want to run the CI/CD step?
Does it make more sense to put this logic in
https://github.com/apache/beam/blob/master/playground/infrastructure/checker.py
where we can create well defined logic for the deleted file case?
##########
.github/workflows/playground_examples_ci_reusable.yml:
##########
@@ -67,7 +67,7 @@ jobs:
if [ -z "$BASE_REF" ] || [ "$BASE_REF" == "master" ]; then
BASE_REF=origin/master
fi
- DIFF=$(git diff --name-only $BASE_REF $GITHUB_SHA | tr '\n' ' ')
+ DIFF=$(git diff --name-only --diff-filter=d $BASE_REF $GITHUB_SHA |
tr '\n' ' ')
Review Comment:
Regardless, we'd probably want to filter on `dr`, not just `d`, right?
https://git-scm.com/docs/git-diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
