olehborysevych commented on code in PR #24819:
URL: https://github.com/apache/beam/pull/24819#discussion_r1059409474
##########
.github/workflows/playground_examples_ci_reusable.yml:
##########
@@ -67,7 +67,7 @@ jobs:
if [ -z "$BASE_REF" ] || [ "$BASE_REF" == "master" ]; then
BASE_REF=origin/master
fi
- DIFF=$(git diff --name-only $BASE_REF $GITHUB_SHA | tr '\n' ' ')
+ DIFF=$(git diff --name-only --diff-filter=d $BASE_REF $GITHUB_SHA |
tr '\n' ' ')
Review Comment:
Thank you Danny, I moved logic responsible for checking if file exists
checker - there is really a potential scenario when deleting a file will break
multi file example. As for filtering on [d] or [dr] it is still worth checking
renamed files as this can also break examples. But the original issue was
caused by trying to open deleted file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
