damccorm commented on code in PR #24819:
URL: https://github.com/apache/beam/pull/24819#discussion_r1060622140
##########
.github/workflows/playground_examples_ci_reusable.yml:
##########
@@ -67,7 +67,7 @@ jobs:
if [ -z "$BASE_REF" ] || [ "$BASE_REF" == "master" ]; then
BASE_REF=origin/master
fi
- DIFF=$(git diff --name-only $BASE_REF $GITHUB_SHA | tr '\n' ' ')
+ DIFF=$(git diff --name-only --diff-filter=d $BASE_REF $GITHUB_SHA |
tr '\n' ' ')
Review Comment:
> As for filtering on [d] or [dr] it is still worth checking renamed files
as this can also break examples. But the original issue was caused by trying to
open deleted file.
Wasn't the original issue caused by a directory rename?
https://github.com/apache/beam/issues/24807 A directory rename would show both
files in the diff I think.
Regardless, the current approach of handling it in `checker.py` should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
