nuggetwheat commented on code in PR #25246:
URL: https://github.com/apache/beam/pull/25246#discussion_r1095128127
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/it/ChangeStreamTestPipelineOptions.java:
##########
@@ -37,8 +37,20 @@ public interface ChangeStreamTestPipelineOptions extends
IOTestPipelineOptions,
void setInstanceId(String value);
@Description("Database ID prefix to write to in Spanner")
- @Default.String("changestream")
+ @Default.String("cs_primary")
String getDatabaseId();
void setDatabaseId(String value);
+
+ @Description("Role-Based Access Control Database ID prefix to write to in
Spanner")
+ @Default.String("cs_rbac")
+ String getRbacDatabaseId();
Review Comment:
Done. We don't need a separate DB client for rbac, just need to specify
SpannerConfig.databaseRole when in RBAC mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
