nuggetwheat commented on code in PR #25246:
URL: https://github.com/apache/beam/pull/25246#discussion_r1096334626
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/it/SpannerChangeStreamIT.java:
##########
@@ -93,6 +103,23 @@ public void before() {
@Test
public void testReadSpannerChangeStream() {
+ testReadSpannerChangeStreamImpl(pipeline, null);
+ }
+
+ @Test
+ public void testReadSpannerChangeStreamWithAuthorizedRole() {
Review Comment:
Yes. If someone (i.e. Apache Beam code) doesn't use the MetadataConfig
constructor to generate the config to access the metadata DB in such a way that
breaks access to the metadata DB, this test will catch it. It is precisely why
I modified this test to use a separate metadata database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
