Abacn commented on code in PR #25246:
URL: https://github.com/apache/beam/pull/25246#discussion_r1095883554
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/it/SpannerChangeStreamIT.java:
##########
@@ -93,6 +101,22 @@ public void before() {
@Test
public void testReadSpannerChangeStream() {
+ testReadSpannerChangeStreamImpl(pipeline, null);
+ }
+
+ @Test
+ public void testReadSpannerChangeStreamWithAuthorizedRole() {
+ testReadSpannerChangeStreamImpl(pipeline, ENV.getDatabaseRole());
+ }
+
+ @Test
+ public void testReadSpannerChangeStreamWithUnauthorizedRole() {
+ exception.expect(SpannerException.class);
Review Comment:
If we only need to validate the error handling on direct runner we can add
something like `assumeTrue(options.getRunner() == DirectRunner.class);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
