je-ik commented on PR #25554: URL: https://github.com/apache/beam/pull/25554#issuecomment-1446332418
> Could we add test to verify that the change brings the expected behavior? > > The test might probably just verify that the metrics are available after running a simple pipeline with some source that updates the metrics. There is an analogous test in `SourceInputFormatTest.testAccumulatorRegistrationOnOperatorClose` that can serve as an inspiration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
