talatuyarer commented on PR #25554: URL: https://github.com/apache/beam/pull/25554#issuecomment-1447448279
Hey @je-ik > I wonder, why do we need to write metrics into the context on checkpoint? The current code does so in the call to `advance()`, is that not sufficient? Current code does not emit backlog metrics on advance. I see it is on checkpointing phase https://github.com/apache/beam/blob/master/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java#L255 Do I miss anything ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
