je-ik commented on PR #25554:
URL: https://github.com/apache/beam/pull/25554#issuecomment-1446374915

   > We have a Flink Job which does not emit backlog metrics. Actually metrics 
are emitting in KafkaIO. However I could not see them on Flink Metric system. 
Looks like Beam -> Flink wiring is broken. I set metricContext in Checkpointing 
phase which is the place metrics emit on UnBoundedReader.
   > 
   > @mxm @tweise @angoenka Could you please review my MR ? I tested in our 
env. It is working as expected.
   
   I wonder, why do we need to write metrics into the context on checkpoint? 
The current code does so in the call to `advance()`, is that not sufficient?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to