tvalentyn commented on code in PR #24599: URL: https://github.com/apache/beam/pull/24599#discussion_r1131449261
########## sdks/python/apache_beam/ml/gcp/__init__.py: ########## @@ -14,3 +14,9 @@ # See the License for the specific language governing permissions and # limitations under the License. # + +# TODO(https://github.com/apache/beam/issues/25625) Review Comment: I don't follow these comments. ########## sdks/python/apache_beam/runners/pipeline_context.py: ########## @@ -310,7 +310,13 @@ def get_or_create_environment_with_resource_hints( """Creates an environment that has necessary hints and returns its id.""" template_env = self.environments.get_proto_from_id(template_env_id) cloned_env = beam_runner_api_pb2.Environment() - cloned_env.CopyFrom(template_env) + # Remove the suppress warning for type once mypy is updated to Review Comment: nit: let's be clear about what minimal version is required until TODO can be lifted. Optionally, you can moe details error in the bug. ########## sdks/python/setup.py: ########## @@ -300,25 +296,25 @@ def get_portability_package_data(): # https://github.com/googleapis/google-cloud-python/issues/10566 'google-auth>=1.18.0,<3', 'google-auth-httplib2>=0.1.0,<0.2.0', - 'google-cloud-datastore>=1.8.0,<2', + 'google-cloud-datastore>=2.0.0,<3', 'google-cloud-pubsub>=2.1.0,<3', 'google-cloud-pubsublite>=1.2.0,<2', # GCP packages required by tests - 'google-cloud-bigquery>=1.6.0,<4', - 'google-cloud-bigquery-storage>=2.6.3,<2.17', - 'google-cloud-core>=0.28.1,<3', - 'google-cloud-bigtable>=0.31.1,<2', + 'google-cloud-bigquery>=2.0.0,<4', + 'google-cloud-bigquery-storage>=2.6.3,<3', + 'google-cloud-core>=2.0.0,<3', + 'google-cloud-bigtable>=2.0.0,<3', 'google-cloud-spanner>=3.0.0,<4', # GCP Packages required by ML functionality 'google-cloud-dlp>=3.0.0,<4', - 'google-cloud-language>=1.3.0,<2', - 'google-cloud-videointelligence>=1.8.0,<2', + 'google-cloud-language>=2.0,<3', + 'google-cloud-videointelligence>=2.0,<3', 'google-cloud-vision>=2,<4', - 'google-cloud-recommendations-ai>=0.1.0,<0.8.0' + 'google-cloud-recommendations-ai>=0.1.0,<1' Review Comment: ```suggestion 'google-cloud-recommendations-ai>=0.1.0,<0.11' ``` ########## sdks/python/test-suites/tox/py38/build.gradle: ########## @@ -103,21 +103,13 @@ test.dependsOn "testPy38pytorch-113" preCommitPyCoverage.dependsOn "testPy38pytorch-113" // Create a test task for each minor version of onnx -toxTask "testPy38onnx-113", "py38-onnx-113", "${posargs}" -test.dependsOn "testPy38onnx-113" -preCommitPyCoverage.dependsOn "testPy38onnx-113" +// toxTask "testPy38onnx-113", "py38-onnx-113", "${posargs}" Review Comment: what is the context for these changes? ########## sdks/python/apache_beam/ml/gcp/naturallanguageml.py: ########## @@ -93,12 +92,11 @@ def AnnotateText( https://cloud.google.com/natural-language/docs. Args: - pcoll (:class:`~apache_beam.pvalue.PCollection`): An input PCollection of - :class:`Document` objects. - features (`Union[Mapping[str, bool], types.AnnotateTextRequest.Features]`): - A dictionary of natural language operations to be performed on given - text in the following format:: + pcoll (:class:`~apache_beam.pvalue.PCollection`): An input PCollection + of :class:`Document` objects. + features: A dictionary of natural language operations to be performed Review Comment: What are the issues w/ keeping the type in the docstring? ########## sdks/python/tox.ini: ########## @@ -320,31 +320,29 @@ commands = # Allow exit code 5 (no tests run) so that we can run this command safely on arbitrary subdirectories. /bin/sh -c 'pytest -o junit_suite_name={envname} --junitxml=pytest_{envname}.xml -n 6 -m uses_pytorch {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret' -[testenv:py{37,38,39,310}-onnx-113] +# [testenv:py{37,38,39,310}-onnx-113] Review Comment: leftover? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
