tvalentyn commented on code in PR #24599: URL: https://github.com/apache/beam/pull/24599#discussion_r1132789015
########## sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio_test.py: ########## @@ -49,8 +49,20 @@ client = None -# TODO(https://github.com/apache/beam/issues/25625) -# remove this FakeMutation and replace it with proto.Message class. +# used for internal testing only +class ByteSize(): Review Comment: Name this class as Fake[ClassNameThatYouAreFaking], for example: FakeMessage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
